-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a page on the Output bottom panel #10333
Add a page on the Output bottom panel #10333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The written content looks generally good, but this is the wrong place to put it. Documentation for print_rich()
does not belong on a page about RichTextLabel
, even if they both happen to use BBCode.
The duplication of BBCode documentation is an ongoing problem, see #9998. Wherever this content ends up, you should probably link to the BBCode reference that already exists in this page. If the BBCode docs are ever consolidated, that link can be redirected to the new BBCode docs.
I am not sure what the best page to put this new content is. If we have a place that already documents print()
, it makes sense, but I don't know if we do. Possibly a page in Scripting/Core Features/Debug is the right place (since prints can be used to debug).
5bb6fce
to
480bc61
Compare
print_rich()
in BBCode in RichTextLabel
This PR now adds a new page on the Output bottom panel, which is linked to on the BBCode in RichTextLabel page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks for making extensive changes like this!
480bc61
to
806a4fc
Compare
Thank you! |
While
print_rich()
works independently of RichTextLabel, it still makes use of BBCode. (I'm not sure if there is another location where this paragraph would be more suitable.)