Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface manual basics #9632

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

vgezer
Copy link
Contributor

@vgezer vgezer commented Jul 21, 2024

This is an initiative to have a detailed manual on editor's interface elements. Which menu does what, where to find a specific tool, etc.

Currently, some useful functionality is discovered by accident. By looking at the merged PRs of such items (e.g., menu items or toolbar buttons) as well as the source code, I am trying to document the usage of each interface element in different sections.

Currently on this page we on this page: https://docs.godotengine.org/en/stable/tutorials/editor/index.html, we have:

Using the Project Manager
The Inspector
Project Settings
Default editor shortcuts
Customizing the interface

No usage of the menus, toolbars etc. I have currently the following items, still WIP:

Editor's Interface:

  • Project Manager
  • Editor's Interface

Interface Elements:

  • Main menus

  • Workspace selector

  • Playtest buttons and renderer

  • Scene switcher

  • Bottom panel

    Default panels, from scratch, or reference to existing pages

  • Docks:

  • Scene Dock (separate commit)

  • Import

  • FileSystem

  • Inspector

  • Node

  • History

Each dock on its own page, either new page, or reference to existing pages.

Customization:

I think it makes sense to have an overview of all interfaces, elements including (basic) usage.

PS: There are also tools to be documented, such as Orphan Resource Explorer, Docks themselves, or some optimization topics such as Customize run instance, but I think this should be the starting point.

@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jul 21, 2024
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback, needs some extensive work for grammar and wording and will go over again when I find the time

tutorials/editor/project_settings.rst Show resolved Hide resolved
tutorials/editor/main_menus.rst Show resolved Hide resolved
tutorials/editor/bottom_panel.rst Show resolved Hide resolved
tutorials/editor/bottom_panel.rst Show resolved Hide resolved
tutorials/editor/bottom_panel.rst Show resolved Hide resolved
tutorials/editor/bottom_panel.rst Show resolved Hide resolved
tutorials/editor/bottom_panel.rst Show resolved Hide resolved
@vgezer vgezer force-pushed the editorintro branch 3 times, most recently from e278a05 to d318036 Compare August 4, 2024 19:08
@vgezer vgezer force-pushed the editorintro branch 3 times, most recently from 39dc595 to 90af831 Compare August 13, 2024 16:05
@vgezer vgezer force-pushed the editorintro branch 2 times, most recently from cc8c1c4 to 7f886a2 Compare October 23, 2024 08:27
@tetrapod00 tetrapod00 added the topic:editor Related to editor features or workflows label Nov 15, 2024
@tetrapod00
Copy link
Contributor

I think #10282 covers the project settings window reasonably well

@tetrapod00
Copy link
Contributor

tetrapod00 commented Dec 3, 2024

Can this be broken up into multiple PRs for the different pages for easier review? Some of the pages here look ready for review, if they were split into individual PRs.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft, but here's a bit of feedback that stood out to me while reading it.

Comment on lines +136 to +138
After making changes, open the `Editor` menu at the top of the editor then
choose `Editor Layouts > Save`. Enter a name for the layout, then click
`Save`. If you've already saved an editor layout, you can choose to override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these should not be changed. The docs generally use Bold for interactible UI buttons, not italics. The docs are currently inconsistent about this, but in #10169 we put this into a formal guideline.

Import Dock
===========

Import dock allows you to change the importing parameters of non-native resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Import dock allows you to change the importing parameters of non-native resources
The Import dock allows you to change the importing parameters of non-native resources

IMO all these pages should start with "The Import dock" or "The Inspector dock" rather than "Import dock" or "Inspector dock".

If the inspector dock is visible, clicking on a node in the scene tree will automatically
display its properties.
If it is not visible, you can show it by navigating to
`Editor > Editor Settings > Editor Docks > Inspector`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Editor > Editor Settings > Editor Docks > Inspector`.
**Editor > Editor Settings > Editor Docks > Inspector**.

As mentioned earlier, generally bold for UI buttons and menu paths like these.

Node Dock
=========

Node dock has two tabs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Node dock has two tabs:
The Node dock has two tabs:

Signals
-------

The `Signals` tab lists the signals of the selected node in the Scene dock which the node can emit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `Signals` tab lists the signals of the selected node in the Scene dock which the node can emit.
The **Signals** tab lists the signals of the selected node in the Scene dock which the node can emit.

@@ -1,7 +1,7 @@
.. _doc_project_manager:

Using the Project Manager
=========================
Project Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! IMO sometimes the docs needlessly uses "Using X" rather than just "X" for titles just to follow a guideline.

@@ -5,12 +5,21 @@
Project Settings
================

This page explains how to use the Project Settings window. If you would like to access and modify project settings via code, see :ref:`ProjectSettings <class_ProjectSettings>`.
.. warning:: This page is a work-in-progress.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have notes of this form. We should bring the page to a correct state, even if it is very short, and not directly comment on future changes within the text of a page.

@@ -0,0 +1,25 @@
.. _doc_workspace_selector:

Workspace selector
Copy link
Contributor

@tetrapod00 tetrapod00 Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if this has an official name in the editor itself, or if it was named a "workspace selector" either in this PR or in a prior docs PR.

I think the name is a good one, but by adding a page here we're solidifying the name as the official one.

in the project.
- **AssetLib** allows you to download plugins and addons for your project. This requires Godot to
be in online mode. Unlike the Asset Library in the project manager, the results will not include
complete game demos. See :ref:`AssetLib <toc-learn-features-assetlib>` for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should probably be to an anchor, not a toc. You might need to add an anchor above the toc.

@vgezer
Copy link
Contributor Author

vgezer commented Dec 9, 2024

Can this be broken up into multiple PRs for the different pages for easier review? Some of the pages here look ready for review, if they were split into individual PRs.

I will go over your comments and try to separate them! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:editor Related to editor features or workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants