Update godot-cpp to godot-4.2-stable
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, not sure why SCons is failing on the CI, it's working for me locally... |
dsnopek
force-pushed
the
godot-cpp-41-branch
branch
2 times, most recently
from
c6d6080 to
a89f4cb
Compare
dsnopek
changed the title
4.1 branchgodot-4.2-stable
|
Per conversation on RocketChat, I've switched this to updating to godot-cpp's Also, I've switched this to DRAFT because it includes the changes from PR #272 so that the CI will pass |
|
#272 is merged, so this can be rebased. |
dsnopek
force-pushed
the
godot-cpp-41-branch
branch
from
a89f4cb to
457cb92
Compare
|
Rebased! |
|
The commit still mentions |
dsnopek
force-pushed
the
godot-cpp-41-branch
branch
from
457cb92 to
900e95d
Compare
|
Ack, sorry! Commit message is fixed in latest push |
akien-mga
approved these changes
May 26, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally updated to the latest in the
4.1branch, but now that Godot 4.1 is no longer supported, this now updates godot-cpp to thegodot-4.2-stablerelease.One of the most important changes this includes is PR godotengine/godot-cpp#1313 which fixes #239, which is a crash that's caused when this GDExtension is used in a project with another GDExtension.
Marking as DRAFT for now, because this includes the changes from PR #272 so that CI will pass
Original description (before 2025-03-24):
This updates the godot-cpp used by this extension to the latest on godot-cpp's
4.1branch.This will mean that the extension will only be compatible with Godot 4.1.4 or later due to the updates to the
extension_api.json. However, if it was important than it still worked with Godot 4.1.0 to 4.1.3, then it should be possible to compile withscons custom_api_file=path/to/extension_api.jsonwhere that JSON file is from Godot 4.1.0 - and we could even stash thatextension_api.jsonin the repo? Anyway, just let me know if you'd like adjustments for that.However, updating to the newest godot-cpp that will work with Godot 4.1 will include a whole bunch of bug fixes that have been cherry-picked since then.
For example, PR godotengine/godot-cpp#1313 which fixes #239
As well as other various memory leaks, crashes, build-system improvements, etc.