CI: Ensure Windows job fails on error #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
ci-windows-fail-on-error
branch
2 times, most recently
from
c89caab to
4b5c2bd
Compare
Calinou
reviewed
May 26, 2025
|
Seems like this fixes the CI issue, as it's now properly reporting the broken Windows build from #199 (comment). We should fix that linking error before merging this PR. |
Merged
akien-mga
force-pushed
the
ci-windows-fail-on-error
branch
from
4b5c2bd to
c128cc6
Compare
akien-mga
force-pushed
the
ci-windows-fail-on-error
branch
from
c128cc6 to
e6f6fed
Compare
Default `pwsh` is apparently not properly configured to fail fast, but `powershell` is, whatever is the difference. Minor tweaks to CI setup.
akien-mga
force-pushed
the
ci-windows-fail-on-error
branch
from
e6f6fed to
51dcc3c
Compare
akien-mga
commented
May 27, 2025
Comment on lines
-44
to
-47
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "3.x" | ||
| architecture: "x64" |
There was a problem hiding this comment.
Removed this as Python is already default installed. One consequence was that the user pip install path was not in PATH anymore, so I changed the installs to be global (which is what we do for Godot too).
akien-mga
commented
May 27, 2025
| run: | | ||
| pip3 install --user scons | ||
| scons platform=windows target=editor generate_bindings=yes -j $env:NUMBER_OF_PROCESSORS |
There was a problem hiding this comment.
Removed the explicit ncpu stuff as this is the default behavior of godot-cpp now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we were running into this infamous issue:
actions/runner-images#6668