Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on "Cancel" when asked about UIDs update does not cancel anything #103066

Open
Nodragem opened this issue Feb 20, 2025 · 2 comments · May be fixed by #103468
Open

Clicking on "Cancel" when asked about UIDs update does not cancel anything #103066

Nodragem opened this issue Feb 20, 2025 · 2 comments · May be fixed by #103468
Labels
discussion topic:editor
Milestone
4.5

Comments

@Nodragem
Copy link
Contributor

Tested versions

4.4 beta4

System information

Godot v4.4.beta4 - Windows 11 (build 22631) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.6119) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 threads)

Issue description

When I opened my project I got this message:

Image

As I did not do a backup, I chose "Cancel" and went to my Git client. I can see that uid files were already created.

Also, once we click on "Cancel", the message does not reappear when restarting the project.

Suggested Solutions:

  • Make sure that "Cancel" prevents any change to the project to allow the user to make a backup
  • Make sure the message is still there when the user has done their backup and are ready to click on "Restart and Upgrade"

Steps to reproduce

Open a 4.3 project with 4.4.

Minimal reproduction project (MRP)

Any 4.3 projects.
@arkology

This comment has been minimized.

Sign in to view
@AThousandShips AThousandShips added this to the 4.4 milestone Feb 20, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Mar 2, 2025

The upgrade tool does not create or prevent creating .uid files. All it does is open and re-save all scenes, so they can update dependencies.
.uid files are created once you open the project, but you can still reverse that by closing the editor, deleting the generated files and removing uid_cache.bin from .godot folder. No project files are modified at that point (other than updated version in project.godot).

This is not a bug, but maybe we could improve the dialog message.

@KoBeWi KoBeWi added discussion and removed bug labels Mar 2, 2025
@adamscott adamscott linked a pull request Mar 2, 2025 that will close this issue
Open
@akien-mga akien-mga moved this from Unassessed to Not Critical in 4.x Release Blockers Mar 2, 2025
@akien-mga akien-mga modified the milestones: 4.4, 4.5 Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion topic:editor
Projects
4.x Release Blockers
Status: Not Critical
Milestone
4.5
Development

Successfully merging a pull request may close this issue.

Update UID upgrade tool dialog message adamscott/godot
5 participants
@KoBeWi @akien-mga @Nodragem @arkology @AThousandShips