Improve emoji SVG parsing by caching #100300
Merged
+246
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
force-pushed
the
improve_emoji
branch
from
52402de to
025ef85
Compare
|
Seem like Windows build fail due to using designated initializers 😞 |
edwin0cheng
force-pushed
the
improve_emoji
branch
2 times, most recently
from
9fcebc1 to
05bddda
Compare
bruvzg
reviewed
Dec 16, 2024
|
And I add fb textserver part too. |
Not sure if a lot can be done for pre-rendering, pre-rendering option only exist because it is slow and primarily for MSDF, it should not be used for emojis in a first place. #88809 actually is not fully related, it's likely caused by fallback lookup for the most part. |
kiroxas
reviewed
Dec 16, 2024
kiroxas
reviewed
Dec 16, 2024
bruvzg
approved these changes
Dec 18, 2024
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
Basically, when we first encounter the document, we parse it as before, but we also note the offsets of other glyphs and store the remaining XML. The next time we see another glyph, we can simply parse that glyph node and insert it back into the stored XML.
edwin0cheng
force-pushed
the
improve_emoji
branch
from
e97548b to
61d3871
Compare
@akien-mga Sure, Done. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache for SVG parsing in the Text Server.
Basically, when we first encounter the document, we parse it as before, but we also note the offsets of other glyphs and store the remaining XML. The next time we see another glyph, we can simply parse that glyph node and insert it back into the stored XML.
Although it is still very slow in the case mentioned in #100278 (which is related to font rendering), the time difference is still significant (on my machine):
Before : 4 mins +
After: 35 secs
Fixes #100278