Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏎️ Replace two-value range loops #324

Merged
merged 19 commits into from
Apr 29, 2020
Merged

🏎️ Replace two-value range loops #324

merged 19 commits into from
Apr 29, 2020

Conversation

Fenny
Copy link
Member

@Fenny Fenny commented Apr 28, 2020

https://garbagecollected.org/2017/02/22/go-range-loop-internals/

Benchmark_i_val_range-4    4132290     303 ns/op     0 B/op    0 allocs/op
Benchmark_i_range-4        4770516     249 ns/op     0 B/op    0 allocs/op
Benchmark_i_len-4          4128156     293 ns/op     0 B/op    0 allocs/op

renanbastos93
renanbastos93 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@renanbastos93 renanbastos93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good job.

@Fenny Fenny merged commit 27a7b21 into gofiber:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanbastos93 renanbastos93 renanbastos93 approved these changes

Assignees

@koddr koddr

@jozsefsallai jozsefsallai

@Fenny Fenny

@thomasvvugt thomasvvugt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fenny @renanbastos93 @koddr @jozsefsallai @thomasvvugt