Skip to content

Add support ec2 instances #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

groorj
Copy link

@groorj groorj commented May 28, 2018

Hi Ville Seppänen,

I added support to EC2 instances termination. Please take a look at the code at your earliest convenience and let me know what you think.

Thanks,
Gustavo

@rasathus
Copy link

Hi @groorj , I stumbled across this change whilst looking at your fork. I was surprised to find the functionality, as there isn't an entry in the config example. After digging a little deeper I think I have discovered why.

It looks as if this new addition is inconsistent with the rest of the project in that it doesn't offer and or observe the 'preserve' list. I'd suggest this is a somewhat dangerous inconsistency, as it could result in unexpected behaviour. My personal recommendation would be to rework this to observe the same preserve list structure as the rest of the services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants