fixed:mssqlserver_insert_and_get #4051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关
修改多语言替换和参数无关 还原无关文件
修改多语言替换和参数无关 还原无关文件 处理测试不通过问题
houseme
reviewed
Dec 17, 2024
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码
houseme
reviewed
Dec 18, 2024
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码
…_id' into fixed_mssqlserver_insert_and_get_id
gqcn
requested changes
Dec 18, 2024
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试 去除不必要的修改
houseme
reviewed
Dec 19, 2024
houseme
reviewed
Dec 19, 2024
gqcn
requested changes
Dec 19, 2024
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试 去除不必要的修改 去除不必要的代码
…_id' into fixed_mssqlserver_insert_and_get_id
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试 去除不必要的修改 去除不必要的代码
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试 去除不必要的修改 去除不必要的代码
…_id' into fixed_mssqlserver_insert_and_get_id
增加注释 撤销修改 修改明明避开包名开头 去除不必要的代码 修改框架DoInsert方法，增加参数，减少重复代码 重写Mssql的DoExec方法达到插入增加返回插入ID的目的 增加多条记录插入测试 去除不必要的修改 去除不必要的代码
gqcn
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the InsertAndGetId method for MSSQL by ensuring that when inserting a record with an auto-increment primary key, the generated ID is correctly returned. Key changes include:
- Adding new test cases and helper functions in the MSSQL unit test files to verify the InsertAndGetId functionality.
- Modifying the driver execution logic in mssql_do_exec.go to incorporate an OUTPUT clause for retrieving the last inserted ID.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contrib/drivers/mssql/mssql_z_unit_init_test.go | Added constants and helper function for creating a test table. |
| contrib/drivers/mssql/mssql_z_unit_basic_test.go | Introduced tests for InsertAndGetId and table name extraction functions. |
| contrib/drivers/mssql/mssql_do_exec.go | Updated SQL execution and output retrieval logic for InsertAndGetId. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复mssqlserver的InsertAndGetId方法；插入记录如果是自增主键则返回ID