Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change audit log label #21703

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Mar 6, 2025

Add more description for update user operation change password or set sys admin

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj added the release-note/update Update or Fix label Mar 6, 2025
@stonezdj stonezdj requested a review from a team as a code owner March 6, 2025 09:35
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.26%. Comparing base (c8c11b4) to head (7e5ea9a).
Report is 404 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21703      +/-   ##
==========================================
+ Coverage   45.36%   46.26%   +0.89%     
==========================================
  Files         244      250       +6     
  Lines       13333    14133     +800     
  Branches     2719     2908     +189     
==========================================
+ Hits         6049     6538     +489     
- Misses       6983     7247     +264     
- Partials      301      348      +47     
Flag Coverage Δ
unittests 46.26% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Vad1mo
Vad1mo previously requested changes Mar 6, 2025
Copy link
Member

@Vad1mo Vad1mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stonezdj can you post a screenshot of UI, where this text is. Its easier to find better wording if you have the UI in front

@stonezdj
Copy link
Contributor Author

stonezdj commented Mar 10, 2025

Screenshot 2025-03-10 at 13 32 45
@Vad1mo could you please remove the request for change so that we could merge the PR?

@stonezdj stonezdj requested review from wy65701436 and chlins March 10, 2025 05:45
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) March 10, 2025 09:10
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the target/2.13.0 issues that are targeting v2.13.0 label Mar 11, 2025
    Add more description for update user operation change password or set sys admin

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 25mar06_refine_audit_log_label branch from 9ed0463 to 7e5ea9a Compare March 12, 2025 03:07
@stonezdj stonezdj merged commit 2065818 into goharbor:main Mar 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix target/2.13.0 issues that are targeting v2.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants