Fix some server/watch rebuild issues #13329
Merged
+59
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues: 1. Fixe potential edit-loop in server/watch mode (see below) 2. Drain the cache eviction stack before we start calculating the change set. This should allow more fine grained rebuilds for bigger sites and/or in low memory situations. The fix in 6c68142 wasn't really fixing the complete problem. In Hugo we have some steps that takes more time than others, one example being CSS building with TailwindCSS. The symptom here is that sometimes when you: 1. Edit content or templates that does not trigger a CSS rebuild => Snappy rebuild. 2. Edit stylesheet or add a CSS class to template that triggers a CSS rebuild => relatively slow rebuild (expected) 3. Then back to content editing or template edits that should not trigger a CSS rebuild => relatively slow rebuild (not expected) This commit fixes this by pulling the dynacache GC step up and merge it with the cache buster step. Fixes gohugoio#13316
bep
force-pushed
the
fix/reloadloop2-13316
branch
from
321212e to
2156828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
The fix in 6c68142 wasn't really fixing the complete problem.
In Hugo we have some steps that takes more time than others, one example being CSS building with TailwindCSS.
The symptom here is that sometimes when you:
This commit fixes this by pulling the dynacache GC step up and merge it with the cache buster step.
Fixes #13316