Add golangci-lint Github Action formatter and lint checks #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the action and set up an initial configuration that passes on the codebase at this point in time.
jmr
requested changes
Apr 3, 2025
jmr
changed the title
Invalid Go toolchain version (1 result)
* go.mod#L0C0:0: As of Go 1.21, toolchain versions [must use the 1.N.P syntax](https://go.dev/doc/toolchain#version).
`1.21` in `go.mod` does not match this syntax and there is no additional `toolchain` directive, which may cause some `go` commands to fail.
(with comments on what the hash is representing
I couldn't find a better resource than https://github.com/dependabot/dependabot-core/blob/main/github_actions/spec/fixtures/workflow_files/pinned_sources_version_comments.yml to document what formats work.
alan-strohm
requested changes
Apr 7, 2025
alan-strohm
requested changes
Apr 8, 2025
|
The push failed because I wasn't sycned up. Now, for really real it is pushed. |
alan-strohm
requested changes
Apr 8, 2025
alan-strohm
reviewed
Apr 8, 2025
alan-strohm
approved these changes
Apr 9, 2025
jmr
requested changes
Apr 9, 2025
jmr
reviewed
Apr 10, 2025
| pull_request: | ||
|
|
||
| permissions: read-all | ||
| # Optional: allow read access to pull request. Use with `only-new-issues` option. |
There was a problem hiding this comment.
These comments don't seem relevant anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a basic configuration that has gofmt and some basic lints enabled.
staticcheck is currently turned off because there are a number of outstanding code elements it flagged in the existing code that need to be fixed up before it should be turned on.