-
Notifications
You must be signed in to change notification settings - Fork 18.4k
net/http/httputil: remove redundant pw.Close() call in DumpRequestOut #75029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 7c38f9f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/696415. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from 黄志文: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Damien Neil: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-08-27T22:31:02Z","revision":"705fe3fa72e598146dbef528685fe5c3ac90e726"} Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Damien Neil: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Damien Neil: Patch Set 1: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
Message from Cherry Mui: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
pw.Close() is already deferred earlier in DumpRequestOut. Change-Id: Icdc9366c816848ed0bb444022d2aa14e4ceaabac GitHub-Last-Rev: 7c38f9f GitHub-Pull-Request: #75029 Reviewed-on: https://go-review.googlesource.com/c/go/+/696415 Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Sean Liao <[email protected]> Auto-Submit: Sean Liao <[email protected]>
Message from Sean Liao: Patch Set 1: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/696415. |
This PR is being closed because golang.org/cl/696415 has been merged. |
pw.Close() is already deferred earlier in DumpRequestOut.