Skip to content

Report packages loading failure with a specific exit-code #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Report packages loading failure with a specific exit-code #4963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/exitcodes/exitcodes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
package exitcodes

import (
"fmt"
)

const (
Success = iota
IssuesFound
Expand All @@ -9,17 +13,24 @@ const (
NoGoFiles
NoConfigFileDetected
ErrorWasLogged
PackagesLoadingFailure
)

type ExitError struct {
Inner error
Message string
Code int
}

func (e ExitError) Error() string {
if e.Inner != nil {
return fmt.Sprintf("%s, %s", e.Message, e.Inner.Error())
}
return e.Message
}

func (e ExitError) Unwrap() error { return e.Inner }

var (
ErrNoGoFiles = &ExitError{
Message: "no go files to analyze",
Expand Down
6 changes: 5 additions & 1 deletion pkg/lint/package.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ func (l *PackageLoader) loadPackages(ctx context.Context, loadMode packages.Load

pkgs, err := packages.Load(conf, args...)
if err != nil {
return nil, fmt.Errorf("failed to load with go/packages: %w", err)
return nil, &exitcodes.ExitError{
Inner: err,
Message: "failed to load with go/packages:",
Code: exitcodes.PackagesLoadingFailure,
}
}

if loadMode&packages.NeedSyntax == 0 {
Expand Down