Changing IP from localhost to that of the machine in the network #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed IP to that of machine in network so that the code can work on multiple systems.
Changed IP to that of machine in network so that the code can work on multiple systems.
fluffybeing
reviewed
Mar 24, 2017
| @@ -3,8 +3,8 @@ import select | |||
| import sys | |||
|
|
|||
| class Server: | |||
| def __init__(self): | |||
| self.host = '' | |||
| def __init__(self, ip): | |||
There was a problem hiding this comment.
No need to make changes here. ~py files are just the swaps. I think .gitignore is not working
fluffybeing
reviewed
Mar 24, 2017
| @@ -217,9 +217,18 @@ def fileno(self): | |||
| def send(self, data): | |||
| self.socket.send(data) | |||
|
|
|||
| class IP_add: | |||
| def getIP(self): | |||
| s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) | |||
There was a problem hiding this comment.
Indentation is not correct at the start of s.
There was a problem hiding this comment.
Do you mean s = socket.socket's start? I think the indentation is okay. It runs without any error.
fluffybeing
reviewed
Mar 24, 2017
| # Create our server instance | ||
| s = Server() | ||
| s = Server(ss.getIP()) |
fluffybeing
requested changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the chat clients are intended to run on different systems, so the server would've to run on its machine's IP. Though I've changed the backup file as well (.py~), it could be deleted too.