added prometheus service to docker-compose #1113

vaibhavjayaraman · 2019-03-08T10:23:10Z

Adding Prometheus service to docker-compose

I created a prometheus.yml file and created a prometheus service in docker-compose.yml.

Fixes #970

vaibhavjayaraman · 2019-03-08T10:27:34Z

docker-compose.yml

+    ports:
+      - 9090:9090 
+    volumes:
+      - ./prometheus.yml:/etc/prometheus/prometheus.yml


Is this the best place to put the yaml file in the container? Also, where should i put prometheus.yml in the source code?

@vaibhavjayaraman I put answers below

Is this the best place to put the yaml file in the container?

inside the container, this seems like the canonical place to put the yaml file, so 👍

Also, where should i put prometheus.yml in the source code?

Check out my answer under https://github.com/gomods/athens/pull/1113/files#r263734261

vaibhavjayaraman · 2019-03-08T10:28:12Z

docker-compose.yml

+      - ./prometheus.yml:/etc/prometheus/prometheus.yml
+    command:
+      - '--config.file=/etc/prometheus/prometheus.yml'
+      - '--storage.tsdb.path=/prometheus'


Should I create another volume for storage and what should I change the storage location in the container?

yes, I think you should create another volume for storage in here

codecov-io · 2019-03-08T10:29:41Z

Codecov Report

❗ No coverage uploaded for pull request base (master@b5a91e8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #1113   +/-   ##
========================================
  Coverage          ?   53.1%           
========================================
  Files             ?      80           
  Lines             ?    2785           
  Branches          ?       0           
========================================
  Hits              ?    1479           
  Misses            ?    1178           
  Partials          ?     128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a91e8...0d29b71. Read the comment docs.

vaibhavjayaraman · 2019-03-08T10:30:34Z

prometheus.yml

+          - targets: ['localhost:9090']
+    - job_name: 'testunit'
+      static_configs:
+        - targets: ['testunit']


When running docker-compose up (and looking at the bash files) it seems that testunit and teste2e get destroyed once they run. Should Prometheus be monitoring these?

@vaibhavjayaraman I don't think so unless you're adding tests for Athens to spit out metrics?

Can you clarify this question for me? Right now I interpret the question to mean that we should include tests that check if the prometheus exporter is working properly by checking if it is spitting out the metrics that we want.

If you wish to add tests for prometheus you are welcome to do so, but if not then you do not need to have prometheus monitor the end to end tests

vaibhavjayaraman · 2019-03-08T10:34:20Z

prometheus.yml

+        - targets: ['teste2e']
+    - job_name: 'athens-proxy'
+      static_configs:
+          - targets: ['athens-proxy:3000']


a persistent athens-proxy service doesn't seem to be part of the docker-compose itself so I wasn't sure I was supposed to make Prometheus monitor it. But I made Prometheus be able to query athens-proxy by running athens-proxy in the same docker network (athens_default) . I am not sure if I should do this.

I made Prometheus be able to query athens-proxy by running athens-proxy in the same docker network (athens_default)

@vaibhavjayaraman I think that's a great start! We can add more tests to look for specific metrics as we go 😄

vaibhavjayaraman · 2019-03-08T10:36:34Z

prometheus.yml

@@ -0,0 +1,18 @@
+global:


Where should I put this file in the source code?

@vaibhavjayaraman can you create a new top-level folder called assets/, and put it in that folder?

arschles

@vaibhavjayaraman thank you so much for this! 😄

I answered as many questions as I could below

🎉

arschles · 2019-03-13T19:19:34Z

prometheus.yml

@@ -0,0 +1,18 @@
+global:


@vaibhavjayaraman can you create a new top-level folder called assets/, and put it in that folder?

arschles · 2019-03-13T19:21:17Z

docker-compose.yml

+    ports:
+      - 9090:9090 
+    volumes:
+      - ./prometheus.yml:/etc/prometheus/prometheus.yml


@vaibhavjayaraman I put answers below

Is this the best place to put the yaml file in the container?

inside the container, this seems like the canonical place to put the yaml file, so 👍

Also, where should i put prometheus.yml in the source code?

Check out my answer under https://github.com/gomods/athens/pull/1113/files#r263734261

arschles · 2019-03-13T21:52:35Z

docker-compose.yml

+      - ./prometheus.yml:/etc/prometheus/prometheus.yml
+    command:
+      - '--config.file=/etc/prometheus/prometheus.yml'
+      - '--storage.tsdb.path=/prometheus'


yes, I think you should create another volume for storage in here

arschles · 2019-03-13T21:53:21Z

prometheus.yml

+          - targets: ['localhost:9090']
+    - job_name: 'testunit'
+      static_configs:
+        - targets: ['testunit']


@vaibhavjayaraman I don't think so unless you're adding tests for Athens to spit out metrics?

arschles · 2019-03-13T21:54:02Z

prometheus.yml

+        - targets: ['teste2e']
+    - job_name: 'athens-proxy'
+      static_configs:
+          - targets: ['athens-proxy:3000']


I made Prometheus be able to query athens-proxy by running athens-proxy in the same docker network (athens_default)

@vaibhavjayaraman I think that's a great start! We can add more tests to look for specific metrics as we go 😄

arschles · 2019-04-08T20:19:14Z

@vaibhavjayaraman just wanted to check in if you're still wanting to work on this? If not, that's totally fine and we can go finish it up

vaibhavjayaraman · 2019-04-08T20:50:13Z

About a week ago, I pushed up another commit (0cfc219) with the changes.

arschles · 2019-04-08T22:05:32Z

Sounds good. Do you want to do this? Otherwise we can do it in a follow-up. It's your choice.

vaibhavjayaraman · 2019-04-14T01:42:39Z

Sure. I can do it, but can you clarify what you mean?

marpio · 2019-05-07T19:54:02Z

@arschles can you answer vaibhavjayaraman's question?

arschles · 2019-07-08T21:59:39Z

@vaibhavjayaraman the link you posted went to https://github.com/gomods/athens/pull/1113/files#r263734261. Would you be able to move the prometheus.yml file to a new assets/ folder at the top level?

Also, regarding your question here: https://github.com/gomods/athens/pull/1113/files#r274158980, I don't think you need to monitor the teste2e and testunit containers, so it is ok if they get destroyed after they run. How does that sound?

arschles · 2019-08-05T21:15:05Z

@vaibhavjayaraman can you let us know if you're still working on this PR? Absolutely no problem if you're not - I can pick it up. I just wanted to check in.

vaibhavjayaraman · 2019-08-19T06:43:54Z

Sorry about my absence. I've been busy lately and don't know when I'll be able to finish this so if it is pressing please feel free to take over.

arschles · 2019-08-21T13:24:48Z

Not a problem @vaibhavjayaraman! AFAIK this isn't pressing for other folks. I'll leave this open for now, and if you get a chance to come back to it, we'll be here. Cheers!

vaibhavjayaraman requested a review from a team as a code owner March 8, 2019 10:23

vaibhavjayaraman commented Mar 8, 2019

View reviewed changes

arschles reviewed Mar 13, 2019

View reviewed changes

vaibhavjayaraman added 2 commits April 2, 2019 20:11

added prometheus service to docker-compose

802c34c

added prometheus service to docker-compose

0cfc219

vaibhavjayaraman force-pushed the prometheus-service branch from 3d53679 to 0cfc219 Compare April 3, 2019 03:16

Merge branch 'master' into prometheus-service

231e881

Merge branch 'master' into prometheus-service

0d29b71

Merge branch 'master' into prometheus-service

d2feb48

Merge branch 'master' into prometheus-service

a9a688a

manugupt1 and others added 2 commits August 19, 2019 22:40

Merge branch 'master' into prometheus-service

5689d74

Merge branch 'master' into prometheus-service

2667194

arschles added 2 commits August 28, 2019 11:50

Merge branch 'master' into prometheus-service

d7cf117

Merge branch 'master' into prometheus-service

3395fb3

arschles changed the base branch from master to main June 15, 2020 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added prometheus service to docker-compose #1113

added prometheus service to docker-compose #1113

vaibhavjayaraman commented Mar 8, 2019

vaibhavjayaraman Mar 8, 2019

arschles Mar 13, 2019

vaibhavjayaraman Mar 8, 2019 •

edited

Loading

arschles Mar 13, 2019

codecov-io commented Mar 8, 2019 •

edited

Loading

vaibhavjayaraman Mar 8, 2019

arschles Mar 13, 2019

vaibhavjayaraman Apr 10, 2019

ghost Sep 17, 2019

vaibhavjayaraman Mar 8, 2019

arschles Mar 13, 2019

vaibhavjayaraman Mar 8, 2019

arschles Mar 13, 2019

arschles left a comment

arschles Mar 13, 2019

arschles Mar 13, 2019

arschles Mar 13, 2019

arschles Mar 13, 2019

arschles Mar 13, 2019

arschles commented Apr 8, 2019

vaibhavjayaraman commented Apr 8, 2019

arschles commented Apr 8, 2019

vaibhavjayaraman commented Apr 14, 2019

marpio commented May 7, 2019

arschles commented Jul 8, 2019

arschles commented Aug 5, 2019

vaibhavjayaraman commented Aug 19, 2019

arschles commented Aug 21, 2019

added prometheus service to docker-compose #1113

Are you sure you want to change the base?

added prometheus service to docker-compose #1113

Conversation

vaibhavjayaraman commented Mar 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaibhavjayaraman Mar 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Mar 8, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arschles left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arschles commented Apr 8, 2019

vaibhavjayaraman commented Apr 8, 2019

arschles commented Apr 8, 2019

vaibhavjayaraman commented Apr 14, 2019

marpio commented May 7, 2019

arschles commented Jul 8, 2019

arschles commented Aug 5, 2019

vaibhavjayaraman commented Aug 19, 2019

arschles commented Aug 21, 2019

vaibhavjayaraman Mar 8, 2019 •

edited

Loading

codecov-io commented Mar 8, 2019 •

edited

Loading