Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELATED: PSDK-160 add name support for user groups #363

Merged
4 commits merged into from
Oct 2, 2023

Conversation

hkad98
Copy link
Contributor

@hkad98 hkad98 commented Oct 1, 2023

No description provided.

@ghost
Copy link

ghost commented Oct 1, 2023

Build succeeded (check pipeline).

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

Merging #363 (b3210a0) into master (3eb6682) will decrease coverage by 0.09%.
Report is 28 commits behind head on master.
The diff coverage is 92.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   91.30%   91.21%   -0.09%     
==========================================
  Files          88       88              
  Lines        5897     5907      +10     
==========================================
+ Hits         5384     5388       +4     
- Misses        513      519       +6     
Files Coverage Δ
...a_sdk/catalog/user/declarative_model/user_group.py 100.00% <100.00%> (ø)
gooddata-sdk/gooddata_sdk/catalog/user/service.py 100.00% <100.00%> (ø)
...oddata_sdk/catalog/user/entity_model/user_group.py 88.33% <91.66%> (-9.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost
Copy link

ghost commented Oct 1, 2023

Build succeeded (check pipeline).

@pcerny pcerny added the merge label Oct 2, 2023
@yenkins
Copy link

yenkins commented Oct 2, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR363

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Oct 2, 2023
@ghost ghost merged commit bf04eeb into gooddata:master Oct 2, 2023
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants