Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIVIAL: gooddata-dbt - better reporting to stdout and pipeline logs #375

Merged
2 commits merged into from
Oct 4, 2023

Conversation

jaceksan
Copy link
Contributor

@jaceksan jaceksan commented Oct 4, 2023

No description provided.

helps to get easier from pipeline logs to corresponding GD env
@ghost
Copy link

ghost commented Oct 4, 2023

Build succeeded (check pipeline).

Copy link
Contributor

@hkad98 hkad98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tabulate dependency to setup.py as well.

@codecov-commenter
Copy link

Codecov Report

Merging #375 (2cb17e9) into master (ec80bbc) will not change coverage.
Report is 10 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          88       88           
  Lines        5907     5907           
=======================================
  Hits         5388     5388           
  Misses        519      519           
Files Coverage Δ
gooddata-fdw/gooddata_fdw/filter.py 86.30% <ø> (ø)
gooddata-sdk/gooddata_sdk/insight.py 81.17% <ø> (ø)
gooddata-sdk/gooddata_sdk/support.py 93.75% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pretty tables
report always, just change the prefix based on if there are any degradations
@ghost
Copy link

ghost commented Oct 4, 2023

Build succeeded (check pipeline).

@hkad98 hkad98 added the merge label Oct 4, 2023
@yenkins
Copy link

yenkins commented Oct 4, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR375

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Oct 4, 2023
@ghost ghost merged commit b48281d into gooddata:master Oct 4, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants