NAS-5251: Add support for dashboard permissions 'share with everyone' #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtoman
requested review from
lupko,
pcerny,
jaceksan and
hkad98
as code owners
|
Build succeeded (check pipeline). |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 91.26% 91.30% +0.03%
==========================================
Files 90 91 +1
Lines 6011 6061 +50
==========================================
+ Hits 5486 5534 +48
- Misses 525 527 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vojtechtoman
changed the title
vojtechtoman
force-pushed
the
nas-5251-share-with-everyone
branch
from
9ae0047 to
5618b86
Compare
|
Build succeeded (check pipeline). |
update tests and fix some of the existing code to work with the oneOf fix/workaround
pcerny
requested changes
Oct 24, 2023
gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/manage_dashboard_permissions.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/manage_dashboard_permissions.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/manage_dashboard_permissions.py
Outdated
Show resolved
Hide resolved
gooddata-sdk/gooddata_sdk/catalog/permission/declarative_model/permission.py
Outdated
Show resolved
Hide resolved
vojtechtoman
force-pushed
the
nas-5251-share-with-everyone
branch
from
5618b86 to
6ab0099
Compare
|
Build succeeded (check pipeline). |
1 similar comment
|
Build succeeded (check pipeline). |
vojtechtoman
force-pushed
the
nas-5251-share-with-everyone
branch
from
2d39211 to
247e1dd
Compare
|
Build succeeded (check pipeline). |
pcerny
approved these changes
Oct 25, 2023
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR392 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model_utils.moustacheto better supportoneOfwith the currently used version of openapi-generatorallWorkspaceUsersrule and fix some of the existing code to work with theoneOffix/workaround