Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAL-1093: update API clients for P32 #400

Merged
1 commit merged into from
Oct 30, 2023

Conversation

Vojtasii
Copy link
Contributor

Now includes composite keys support. LDM dataset references have a new "sources" option and "sourceColumns" are now Optional. This property is returned only if GDC_FEATURES_ENABLE_COMPOSITE_GRAIN=true

@ghost
Copy link

ghost commented Oct 30, 2023

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Oct 30, 2023

Build succeeded (check pipeline).

Now includes composite keys support. LDM dataset references
have a new "sources" option and "sourceColumns" are now Optional.
This property is returned only if GDC_FEATURES_ENABLE_COMPOSITE_GRAIN=true
@ghost
Copy link

ghost commented Oct 30, 2023

Build succeeded (check pipeline).

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #400 (d2ac3db) into master (c3772ac) will increase coverage by 0.06%.
Report is 30 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
+ Coverage   91.19%   91.25%   +0.06%     
==========================================
  Files          90       91       +1     
  Lines        6005     6075      +70     
==========================================
+ Hits         5476     5544      +68     
- Misses        529      531       +2     
Files Coverage Δ
gooddata-sdk/gooddata_sdk/__init__.py 100.00% <ø> (ø)
...mission/declarative_model/dashboard_permissions.py 89.36% <ø> (-0.12%) ⬇️
.../declarative_model/manage_dashboard_permissions.py 100.00% <ø> (+5.26%) ⬆️
...catalog/permission/declarative_model/permission.py 98.14% <ø> (-1.86%) ⬇️
...ata-sdk/gooddata_sdk/catalog/permission/service.py 100.00% <ø> (ø)
gooddata-sdk/gooddata_sdk/catalog/rule.py 100.00% <ø> (ø)
gooddata-sdk/gooddata_sdk/catalog/setting.py 90.90% <ø> (+0.43%) ⬆️
...model/workspace/analytics_model/analytics_model.py 97.86% <ø> (-0.47%) ⬇️
...e_model/workspace/logical_model/dataset/dataset.py 93.33% <ø> (-0.31%) ⬇️
...e/declarative_model/workspace/logical_model/ldm.py 92.85% <ø> (-1.81%) ⬇️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hkad98 hkad98 added the merge label Oct 30, 2023
@yenkins
Copy link

yenkins commented Oct 30, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR400

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Oct 30, 2023
@ghost ghost merged commit 87aecc7 into gooddata:master Oct 30, 2023
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants