Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DP-2706 Adding enforcing api token related APIs to documentation #402

Merged
1 commit merged into from
Nov 1, 2023
Merged

DP-2706 Adding enforcing api token related APIs to documentation #402

1 commit merged into from
Nov 1, 2023

Conversation

JKlucka
Copy link
Contributor

@JKlucka JKlucka commented Nov 1, 2023

No description provided.

@ghost
Copy link

ghost commented Nov 1, 2023

Build succeeded (check pipeline).

Mara3l
Mara3l requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Mara3l Mara3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the markdown files. Also please update the _index.md in the same directory and add all of these methods to the list at the line 15

docs/content/en/docs/administration/permissions/manage_organization_permissions.md Outdated

``manage_organization_permissions(organization_permission_assignments: List[CatalogOrganizationPermissionAssignment])``

Manage organization the permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Manage organization the permissions.
Manage the permissions of the whole organization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/content/en/docs/administration/permissions/get_declarative_organization_permissions.md Outdated

Gets the current set of permissions of the workspace in a declarative form.

{{% parameters-block title="Parameters"%}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% parameters-block title="Parameters"%}}
{{% parameters-block title="Parameters" None="yes" %}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

docs/content/en/docs/administration/permissions/put_declarative_organziation_permissions.md Outdated

``put_declarative_organization_permissions(org_permissions: CatalogDeclarativeOrganizationPermission)``

Sets the permissions for the organziation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sets the permissions for the organziation.
Sets the permissions for the whole organization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/content/en/docs/administration/permissions/manage_organization_permissions.md Outdated

{{% parameters-block title="Parameters"%}}
{{< parameter p_name="organization_permission_assignments" p_type="List[CatalogOrganizationPermissionAssignment]" >}}
List of Object Containing Organization Permissions Assignments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List of Object Containing Organization Permissions Assignments.
List of Organization Permission Assignments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/content/en/docs/administration/permissions/put_declarative_organziation_permissions.md Outdated

{{% parameters-block title="Parameters"%}}
{{< parameter p_name="org_permissions" p_type="List[CatalogDeclarativeOrganizationPermission]" >}}
List of Objects Containing Organization Permissions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List of Objects Containing Organization Permissions.
List of Organization Permissions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mara3l Mara3l closed this Nov 1, 2023
@Mara3l Mara3l reopened this Nov 1, 2023
@ghost
Copy link

ghost commented Nov 1, 2023

Build succeeded (check pipeline).

@ghost
Copy link

ghost commented Nov 1, 2023

Build succeeded (check pipeline).

@JKlucka
Copy link
Contributor Author

JKlucka commented Nov 1, 2023

@Mara3l thanks for the review. updated as recommended. May I ask for second round, please? Thank you

Mara3l
Mara3l requested changes Nov 1, 2023
View reviewed changes
docs/content/en/docs/administration/permissions/put_declarative_organziation_permissions.md Outdated
@@ -0,0 +1,29 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the name of the file, please update to put_declarative_organization_permissions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JKlucka This would be the last change :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, sorry for that! Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @Mara3l

@ghost
Copy link

ghost commented Nov 1, 2023

Build succeeded (check pipeline).

@Mara3l Mara3l added the merge label Nov 1, 2023
@yenkins
Copy link

yenkins commented Nov 1, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR402

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Nov 1, 2023
@ghost ghost merged commit 89ed410 into gooddata:master Nov 1, 2023
1 check passed
@ghost
Copy link

ghost commented Nov 1, 2023

Build succeeded (gate pipeline).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mara3l Mara3l Mara3l approved these changes

@lupko lupko Awaiting requested review from lupko lupko is a code owner

@pcerny pcerny Awaiting requested review from pcerny pcerny is a code owner

@jaceksan jaceksan Awaiting requested review from jaceksan jaceksan is a code owner

@hkad98 hkad98 Awaiting requested review from hkad98 hkad98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JKlucka @yenkins @Mara3l