Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIVIAL: fix wrong definition for workspace permissions #406

Merged
3 commits merged into from
Nov 2, 2023

Conversation

hkad98
Copy link
Contributor

@hkad98 hkad98 commented Nov 2, 2023

No description provided.

There is a broken relationship between CatalogDeclarativeDashboardPermissionsForAssignee and CatalogPermissionsForAssigneeIdentifier. One has attribute name assignee and the second one has assignee identifier. Note that the naming should be the same.
@ghost
Copy link

ghost commented Nov 2, 2023

Build succeeded (check pipeline).

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #406 (49ac3a5) into master (5af29ca) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   91.30%   91.33%   +0.03%     
==========================================
  Files          91       91              
  Lines        6105     6105              
==========================================
+ Hits         5574     5576       +2     
+ Misses        531      529       -2     
Files Coverage Δ
gooddata-sdk/gooddata_sdk/__init__.py 100.00% <ø> (ø)
.../declarative_model/manage_dashboard_permissions.py 100.00% <100.00%> (ø)
...catalog/permission/declarative_model/permission.py 100.00% <100.00%> (+1.42%) ⬆️
...ata-sdk/gooddata_sdk/catalog/permission/service.py 100.00% <ø> (ø)
...model/workspace/analytics_model/analytics_model.py 98.39% <100.00%> (+0.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ghost
Copy link

ghost commented Nov 2, 2023

Build succeeded (check pipeline).

@hkad98 hkad98 added the merge label Nov 2, 2023
@yenkins
Copy link

yenkins commented Nov 2, 2023

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR406

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Nov 2, 2023
@ghost ghost merged commit dbe406a into gooddata:master Nov 2, 2023
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants