Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify_mapped_data_source add support for SQL datasets #836

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: modify_mapped_data_source add support for SQL datasets #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gooddata-sdk/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/ldm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ def modify_mapped_data_source(self, data_source_mapping: Optional[dict]) -> Cata
data_source_id = dataset.data_source_table_id.data_source_id
if data_source_id in data_source_mapping:
dataset.data_source_table_id.data_source_id = data_source_mapping[data_source_id]
if dataset.sql is not None:
data_source_id = dataset.sql.data_source_id
if data_source_id in data_source_mapping:
dataset.sql.data_source_id = data_source_mapping[data_source_id]
return self

@staticmethod
Expand Down
Loading