Add support for ExportDefinition #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: TRIVIAL risk: low
There was an issue resolving oneOf. A workaround was introduced some time ago, but it did not work for ExportDefinitionRequest. ExportDefinitionRequest was correctly matched, but it did not pass the assert, so it failed with the error that none oneOf could be used. Therefore, assert was extended for the use case when all model_kwargs are presented in oneof_class.openapi_types. This new condition and the old one should cover both cases. JIRA: PSDK-209 risk: low
JIRA: PSDK-209 risk: low
JIRA: PSDK-209 risk: low
hkad98
force-pushed
the
jkd/export-definition
branch
from
097f3aa to
68949c8
Compare
pcerny
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.