Update base_options.py Fix Windows Path Concatenation Issue with mode… #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_asset_path in MediaPipe Tasks Summary: This PR addresses a bug in MediaPipe on Windows where specifying model_asset_path for MediaPipe tasks (such as FaceLandmarker) results in an invalid path concatenation. This error does not appear on Linux or macOS and occurs specifically when _TaskRunner concatenates the absolute model_asset_path with default internal paths, leading to issues such as errno=22 due to an invalid file path. Issue Description: When BaseOptions.model_asset_path is used on Windows, the underlying _TaskRunner component incorrectly concatenates the provided path with a directory in site-packages, leading to an inaccessible or incorrect path. This results in the error: RuntimeError: Unable to open file at C:\Users\...\site-packages/C:\Users\...\face_landmarker.task, errno=22 The error occurs only on Windows, likely due to platform-specific handling of absolute paths. Proposed Solution: 1) Detecting the Windows platform. 2) Attempting to load the model file directly into model_asset_buffer if model_asset_path is provided. 3) Setting model_asset_path to None if the model is successfully loaded into model_asset_buffer, bypassing the problematic path concatenation in _TaskRunner.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses a bug in MediaPipe on Windows where specifying model_asset_path for MediaPipe tasks (such as FaceLandmarker) results in an invalid path concatenation. This error does not appear on Linux or macOS and occurs specifically when _TaskRunner concatenates the absolute model_asset_path with default internal paths, leading to issues such as errno=22 due to an invalid file path.
Issue Description:
When BaseOptions.model_asset_path is used on Windows, the underlying _TaskRunner component incorrectly concatenates the provided path with a directory in site-packages, leading to an inaccessible or incorrect path. This results in the error:
RuntimeError: Unable to open file at C:\Users\...\site-packages/C:\Users\...\face_landmarker.task, errno=22The error occurs only on Windows, likely due to platform-specific handling of absolute paths.
Proposed Solution: