Enable clang-analyzer-deadcode.DeadStores

google · Nov 12, 2024 · 1c554ae · 1c554ae
1 parent ed7aaaf
commit 1c554ae
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/base/cvd/.clang-tidy b/base/cvd/.clang-tidy
@@ -7,7 +7,6 @@ WarningsAsErrors: >
   clang-analyzer-*,
   -clang-analyzer-core.uninitialized.Assign,
   -clang-analyzer-core.UndefinedBinaryOperatorResult,
-  -clang-analyzer-deadcode.DeadStores,
   clang-diagnostic-*,
   -clang-diagnostic-pragma-once-outside-header,
   -clang-diagnostic-unused-const-variable,

diff --git a/base/cvd/cuttlefish/common/libs/utils/files.cpp b/base/cvd/cuttlefish/common/libs/utils/files.cpp
@@ -246,9 +246,8 @@ bool IsDirectoryEmpty(const std::string& path) {
     return false;
   }
 
-  decltype(::readdir(direc)) sub = nullptr;
   int cnt {0};
-  while ( (sub = ::readdir(direc)) ) {
+  while (::readdir(direc)) {
     cnt++;
     if (cnt > 2) {
     LOG(ERROR) << "IsDirectoryEmpty test failed with " << path

diff --git a/base/cvd/cuttlefish/host/commands/cvd/cli/commands/cmd_list.cpp b/base/cvd/cuttlefish/host/commands/cvd/cli/commands/cmd_list.cpp
@@ -43,7 +43,6 @@ class CvdCmdlistHandler : public CvdServerHandler {
 
     CF_EXPECT(CanHandle(request));
 
-    auto [subcmd, subcmd_args] = ParseInvocation(request);
     const auto subcmds = executor_.CmdList();
 
     std::vector<std::string> subcmds_vec{subcmds.begin(), subcmds.end()};