Rewrite orchestration e2e test in go. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
force-pushed
the
orch-e2etest-golang
branch
3 times, most recently
from
5088e88 to
64f28ff
Compare
ser-io
requested review from
ikicha,
0405ysj,
Databean,
rmuthiah,
jmacnak and
adelva1984
as code owners
ser-io
removed request for
adelva1984,
rmuthiah,
Databean,
jmacnak,
ikicha and
0405ysj
ser-io
force-pushed
the
orch-e2etest-golang
branch
2 times, most recently
from
31b54fa to
fc41d83
Compare
ser-io
force-pushed
the
orch-e2etest-golang
branch
from
fc41d83 to
a304585
Compare
jemoreira
approved these changes
May 9, 2024
Comment on lines
+3
to
+10
| http_archive( | ||
| name = "io_bazel_rules_go", | ||
| integrity = "sha256-fHbWI2so/2laoozzX5XeMXqUcv0fsUrHl8m/aE8Js3w=", | ||
| urls = [ | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", | ||
| "https://github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Can the bazel central registry be used instead of the http_archive approach?
There was a problem hiding this comment.
I think so, there's support for Go with Bzlmod https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/bzlmod.md, will work on what could be migrated in a following PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.