Refactors for automatic cache pruning #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
auto_cache_prune_prep
branch
from
7e715da to
7448680
Compare
Databean
approved these changes
Jan 15, 2025
cjreynol
force-pushed
the
auto_cache_prune_prep
branch
from
7448680 to
d116c61
Compare
The previous signature was a relic from the `fetch_cvd` stand-alone executable. Now that `fetch` is only a `cvd` subcommand there is no more need for the compatibility conversion. Test: cvd fetch --target_directory=/tmp/cvd --default_build=aosp-main/aosp_cf_x86_64_phone-trunk_staging-userdebug
The main motivation is that we want the flag values (specifically `enable_caching`) to be available in the fetch command so we can use it as a signal to trigger the cache pruning logic. This change also has the benefit of removing non-fetch logic from `FetchCvdMain`. Test: cvd fetch --target_directory=/tmp/cvd/fetch_test --default_build=aosp-main/aosp_cf_x86_64_phone-trunk_staging-userdebug Test: cvd fetch --help Test: cvd help fetch
For the automatic cache management, rather than call `cvd cache` directly we will call `RunPrune` and bypass the `CommandHandler`. Test: cvd cache info Test: cvd cache prune Test: cvd cache empty
cjreynol
force-pushed
the
auto_cache_prune_prep
branch
from
d116c61 to
49d526b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the boundary between
CvdFetchCommandHandler/FetchCvdMainand make cache logic available for use in thefetchhandler.The main changes are around the
FetchCvdMainparameters. Everything else should be a move or rename.Test: cvd fetch --target_directory=/tmp/cvd
--default_build=aosp-main/aosp_cf_x86_64_phone-trunk_staging-userdebug
Test: cvd fetch --help
Test: cvd help fetch
Test: cvd cache info
Test: cvd cache prune
Test: cvd cache empty