Automatically prune the fetch cache after fetches #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
fetch_auto_prune
branch
from
03cefc0 to
1bfdea4
Compare
cjreynol
requested review from
Databean,
rmuthiah,
jemoreira and
ser-io
as code owners
Databean
approved these changes
Jan 16, 2025
cjreynol
force-pushed
the
fetch_auto_prune
branch
from
1bfdea4 to
980483c
Compare
Keeps the fetch cache from growing unbounded. Test: # populate cache if necessary Test: cvd fetch --target_directory=/tmp/cvd/fetch_test --default_build=12924704,12924909,12924919 Test: cvd cache info Test: cvd fetch --target_directory=/tmp/cvd/fetch_test2 --default_build=12924921 --max_cache_size_GB=2 Test: # only prunes when caching is enabled Test: cvd fetch --target_directory=/tmp/cvd/fetch_test3 --default_build=12924578 --max_cache_size_GB=0 --enable_caching=false Test: cvd cache info
cjreynol
force-pushed
the
fetch_auto_prune
branch
from
980483c to
c581683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps the fetch cache from growing unbounded.
Test: # populate cache if necessary
Test: cvd fetch --target_directory=/tmp/cvd/fetch_test
--default_build=12924704,12924909,12924919
Test: cvd cache info
Test: cvd fetch --target_directory=/tmp/cvd/fetch_test2
--default_build=12924921 --max_cache_size_GB=2
Test: # only prunes when caching is enabled
Test: cvd fetch --target_directory=/tmp/cvd/fetch_test3
--default_build=12924578 --max_cache_size_GB=0 --enable_caching=false
Test: cvd cache info