Consolidate argument parsers #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: b/389804379 Test: /usr/bin/bazel test '...'
cjreynol
approved these changes
Jan 16, 2025
jemoreira
approved these changes
Jan 16, 2025
Databean
force-pushed
the
consume_constrained
branch
from
e3541ac to
08369a2
Compare
|
Thanks for reviewing! |
This parses arguments until an unrecognized argument is encountered. Bug: b/389804379 Test: /usr/bin/bazel test '...'
This reuses the same parsing logic as actual subcommand implementations. Bug: b/389804379 Test: /usr/bin/bazel run :cvd Test: /usr/bin/bazel run :cvd -- create Test: /usr/bin/bazel run :cvd -- create Test: /usr/bin/bazel run :cvd -- help Test: /usr/bin/bazel run :cvd -- --instance_name 1 status Test: /usr/bin/bazel run :cvd -- --instance_name=1 status Test: /usr/bin/bazel run :cvd -- status
Bug: b/389804379 Test: /usr/bin/bazel test '//...'
This is no longer being used. Bug: b/389804379 Test: /usr/bin/bazel test '//...'
Databean
force-pushed
the
consume_constrained
branch
from
08369a2 to
588ffcd
Compare
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Jan 21, 2025
Introduces a dependency on libxml2. Restores parts of tests deleted in google#853 Bug: b/389804379 Test: bazel test '//...'
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Introduces a dependency on libxml2. Restores parts of tests deleted in #853 Bug: b/389804379 Test: bazel test '//...'
jrguzman-ms
pushed a commit
to msft-mirror-aosp/device.google.cuttlefish
that referenced
this pull request
Jan 22, 2025
... for parity with google/android-cuttlefish#853 Bug: b/389804379 Test: atest --host libcuttlefish_utils_test Change-Id: Ibc9747a8d6201aa09585ac3b6b47f563c04900ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
ArgumentLexerwith theFlagargument handling.Bug: b/389804379
Test: