Copy logcat_receiver from AOSP
#859
Open
+123
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the headers were available, not the implementations. The new binary also depends on the implementations. Test: bazel build //cuttlefish/host/libs/config:config
cjreynol
force-pushed
the
logcat_receiver_copy
branch
from
43cd8f0 to
efad2ae
Compare
cjreynol
requested review from
Databean,
rmuthiah,
jemoreira and
ser-io
as code owners
Databean
reviewed
Jan 21, 2025
base/cvd/cuttlefish/host_tools/host/commands/logcat_receiver/main.cpp
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,83 @@ | |||
| /* | |||
There was a problem hiding this comment.
Is there a possibility here to use the minimerge tool to generate commits to fill in the git blame of the file?
Import from AOSP - https://cs.android.com/android/platform/superproject/main/+/main:device/google/cuttlefish/host/commands/logcat_receiver/main.cpp;drc=b601a7aeaf2790b0ecf9444ecbd10caa6fad2b8d I did let `clang-format` run on the file, but there are no other changes The added `.../logcat_receiver/main.cpp` file is not for review in this repository. The intention is to verify it against changes made in Github for now, in preparation for eventually moving more of our host tools. Test: bazel build //cuttlefish/host_tools/host/commands/logcat_receiver:logcat_receiver
cjreynol
force-pushed
the
logcat_receiver_copy
branch
from
efad2ae to
bb158ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From AOSP - https://cs.android.com/android/platform/superproject/main/+/main:device/google/cuttlefish/host/commands/logcat_receiver/main.cpp;drc=b601a7aeaf2790b0ecf9444ecbd10caa6fad2b8d
I did let
clang-formatrun on the file, but there are no other changes.The added
.../logcat_receiver/main.cppfile is not for review inthis repository. The intention is to verify it against changes made in
Github for now, in preparation for eventually moving more of our host
tools.
Test: bazel build
//cuttlefish/host_tools/host/commands/logcat_receiver:logcat_receiver