Add Launch and Submission Timestamps to QR #2672
Merged
+177
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jingtang10
reviewed
Sep 17, 2024
...e/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponses.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Sep 17, 2024
...c/test/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponsesTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Sep 17, 2024
...c/test/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponsesTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Sep 17, 2024
...c/test/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponsesTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Oct 1, 2024
There was a problem hiding this comment.
thanks for creating this new pr @hamza-vd
a few small comments
...e/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponses.kt
Outdated
Show resolved
Hide resolved
...src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelParameterizedTest.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Oct 8, 2024
...e/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireResponses.kt
Outdated
Show resolved
Hide resolved
...src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelParameterizedTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Oct 15, 2024
...src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelParameterizedTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Oct 15, 2024
...src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelParameterizedTest.kt
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
November 19, 2024 11:57
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2372
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.