Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for 'using declarations' with std::string #1418

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

calebfletcher
Copy link
Contributor

Adding two integration tests for #1379. Each one produces the same underlying error but seemingly in different parts of autocxx.

Inlining the std::string in place of the string usages causes the tests to pass correctly, so this does appear to be something in autocxx or bindgen not correctly identifying std::string in order to replace it with CxxString.

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

google-cla bot commented Dec 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adetaylor
Copy link
Collaborator

Thanks for this - it'll make it much easier for me to take a look. I'm away for a few weeks at the moment so there will be a bit more of a delay.

@adetaylor adetaylor mentioned this pull request Jan 8, 2025
@adetaylor adetaylor merged commit aff3e6a into google:main Jan 8, 2025
12 of 19 checks passed
@adetaylor
Copy link
Collaborator

Thanks, these tests no longer produce a problem on latest autocxx (0.27.1) - I've merged them for better test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants