Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support build-apks with mode=universal that baseline.prof packaging to apks #297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ethanhua
Copy link

@ethanhua ethanhua commented Jul 13, 2022

fix like #295

@google-cla
Copy link

google-cla bot commented Jul 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@maxirosson
Copy link

Hi. This is working using the bundletool-all-1.11.1.jar but NOT working if we use the JAR downloaded from Google Repo.

object Main {
    @JvmStatic
    fun main(args: Array<String>) {
        val myArgs = listOf("build-apks",
            "--bundle=/PATH/TO/app-release.aab",
            "--output=/PATH/TO/output",
            "--output-format=DIRECTORY",
            "--mode=default",
            "--aapt2=/PATH/TO/android-sdk/build-tools/33.0.0/aapt2"
        )

        // This is NOT generating the /assets/dexopt/baseline.prof file on base-master.apk
        BundleToolMain.main(myArgs.toTypedArray())

        // But if I run bundletool-all-1.11.1.jar by command line, it is working fine:
        //java -jar ./bundletool-all-1.11.1.jar build-apks --bundle=/PATH/TO/app-release.aab --output=/PATH/TO/output --output-format="DIRECTORY" --mode="default" --aapt2=/PATH/TO/android-sdk/build-tools/33.0.0/aapt2

    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants