versions updated; deprecated configurations updated. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Sep 27, 2018
| @@ -1,4 +1,4 @@ | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.5.1-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-bin.zip | |||
There was a problem hiding this comment.
Any reason to stay so low? 4.10.2 is latest
There was a problem hiding this comment.
that's just the current "least" version for build-tools 3.2.0.
….files() instead of TaskInputs.file() ).
plecesne
reviewed
Sep 27, 2018
| @@ -3,3 +3,4 @@ | |||
| /out | |||
| /.idea | |||
| /.gradle | |||
| /local.properties | |||
There was a problem hiding this comment.
nit: Move before the "/out" to keep in alphabetical order (although I realize now that the gradle is incorrectly placed...)
| compileWindows "com.android.tools.build:aapt2:3.2.0-alpha14-4748712:windows" | ||
| compileMacOs "com.android.tools.build:aapt2:3.2.0-alpha14-4748712:osx" | ||
| compileLinux "com.android.tools.build:aapt2:3.2.0-alpha14-4748712:linux" | ||
| compileWindows "com.android.tools.build:aapt2:3.2.0:windows" |
There was a problem hiding this comment.
I think the stable version is: 3.2.0-4818971
plecesne
reviewed
Oct 2, 2018
| shadow "com.google.errorprone:error_prone_annotations:2.2.0" | ||
| shadow "com.google.guava:guava:26.0-jre" | ||
| shadow "com.google.protobuf:protobuf-java:3.4.0" | ||
| shadow "com.google.protobuf:protobuf-java-util:3.4.0" | ||
| shadow "com.google.protobuf:protobuf-java:3.6.1" |
There was a problem hiding this comment.
If you could switch to 3.6.0 instead, that would be helpful. We can't use 3.6.1 on our internal branch at the moment.
shaomaicheng
pushed a commit
to shaomaicheng/bundletool
that referenced
this pull request
Dec 20, 2020
Updates all yaml files to correct github path.
aseeily25
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.