Skip to content

Conversation

dillon-giacoppo
Copy link

@dillon-giacoppo dillon-giacoppo commented Jun 29, 2025

Fix for: #3643

containerd snapshotter is an experimental feature https://github.com/docker/docs/blob/1da5f51da8a9c40c4318c8cec90b3939f0a25ca2/content/manuals/engine/storage/containerd.md that uses the containerd image store.

Using containerd offers multiple benefits, primarily multi-platform images and wasm container support.

When user containerd-snapshotter, rootfs points to the wrong directory leading to error in cadvisor:

manager.go:1116] Failed to create existing container: ... failed to identify the read-write layer ID for container "<CONTAINER_ID>". - open /rootfs/var/lib/docker/image/overlayfs/layerdb/mounts/<CONTAINER_ID>/mount-id: no such file or directory

This PR adds support for overlayfs driver and retrieves the root path from containerd spec directly. With this PR the containers can be loaded successfully:

image

Copy link
Collaborator

@iwankgb iwankgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more than happy to give it a chance, but I am no longer able to merge PRs in cAdvisor.

@wolfspyre
Copy link

curious why this isn't merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants