Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Add more details of the http request #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhananjaysathe
Copy link
Contributor

Use nt/http/httptrace for getting more detailed metrics from the http probes

  • Expose time taken for each phase dns resolution, connection, tls handshake, request send and reciept of first byte.
  • use end misc latency times from net/http/httptrace callbacks directly
  • Backward compatible with original http probe

- Expose time taken for each phase dns resolution, connection, tls handshake, request send and reciept of first byte.
- use end misc latency times from net/http/httptrace callbacks directly
- Backward compatible with original http probe
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@dhananjaysathe
Copy link
Contributor Author

cc @manugarg this adds more fine-grained metrics

@manugarg
Copy link
Contributor

@dhananjaysathe Sorry for the delay in reviewing this PR. Unfortunately, adding more metrics affects everyone, so we'd want to enable them only through a configurable option. But, before you make any further changes, let me take a look at it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants