Fix note about undefined behavior #2632
Open
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So turns out this example does trigger undefined behavior. It's undefined behavior to use a pointer to read past the end of the object from which the pointer was originally created. So even though we know there's another array past the end of the first one, it's still undefined behavior to read past the end of the array if we created the initial pointer from the first array. You can see this if you run miri in the playground. If we tweak the example to instead take a pointer to the struct as a whole it runs through miri with no errors, since now we're allowed to read the full contents of the struct.
Isn't undefined behavior fun? 🙃