-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update to Rust 2024 edition. #2658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
40a6949
to
05c4b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff looks good!
52c320f
to
f5787fe
Compare
815bdd5
to
b9641a7
Compare
This is blocked on a new version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to manually build the book with these changes (after manual installation of mdbook-svgbob from the git repo - as there is no release yet) I get this error from linkcheck (0.7.7)
$ mdbook build
2025-04-17 09:29:35 [INFO] (mdbook::book): Book building has started
2025-04-17 09:29:35 [INFO] (mdbook::book): Running the exerciser backend
2025-04-17 09:29:35 [INFO] (mdbook::renderer): Invoking the "exerciser" renderer
2025-04-17 09:29:35 [INFO] (mdbook::book): Running the html backend
2025-04-17 09:29:36 [INFO] (mdbook::book): Running the linkcheck backend
2025-04-17 09:29:36 [INFO] (mdbook::renderer): Invoking the "linkcheck" renderer
Error: Unable to parse RenderContext
Caused by:
unknown variant `2024`, expected one of `2021`, `2018`, `2015` for key `edition` at line 1 column 702979
2025-04-17 09:29:36 [ERROR] (mdbook::renderer): Renderer exited with non-zero return code.
2025-04-17 09:29:36 [ERROR] (mdbook::utils): Error: Rendering failed
2025-04-17 09:29:36 [ERROR] (mdbook::utils): Caused By: The "linkcheck" renderer failed
When linkcheck is disabled this change looks good to me.
mdbook-linkcheck hasn't had a release in 2 years and doesn't support Rust 2024 edition.
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still the issue with the new crate version mdbook-svgbob 0.2.2 not yet pushed but otherwise this now looks good to me!
No description provided.