Don't store XElement outside of processing rounds. #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
`GeneratesRootInputProcessorTest` stores the `List<XElement>` returned by `GeneratesRootInputs.getElementsToWaitFor()` to test the output. However, this causes an issue with the latest XProcessing drop when trying to access the fully qualified name of the element outside of the actual processing rounds. This is fixed if we replaced the `List<XElement>` with `List<String>` and calculate the qualified name immediately inside the processing round. RELNOTES=N/A PiperOrigin-RevId: 720687140
copybara-service
bot
force-pushed
the
test_720433172
branch
from
a1c7209 to
81ea86a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't store XElement outside of processing rounds.
GeneratesRootInputProcessorTeststores theList<XElement>returned byGeneratesRootInputs.getElementsToWaitFor()to test the output. However, this causes an issue with the latest XProcessing drop when trying to access the fully qualified name of the element outside of the actual processing rounds. This is fixed if we replaced theList<XElement>withList<String>and calculate the qualified name immediately inside the processing round.RELNOTES=N/A