vk: workaround swiftshader spirv no-op issue #7417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftshader runs spirv validation before compilation. However, the validation does not like having Nop (no-op) in the input. So we skip instructions instead of writing no-op for the output of `workaroundSpecConstant`. Also, fix issue to keep the value in the original shader if a specialization wasn't provided.
bejado
approved these changes
Dec 8, 2023
poweifeng
added a commit
that referenced
this pull request
Dec 8, 2023
Swiftshader runs spirv validation before compilation. However, the validation does not like having Nop (no-op) in the input. So we skip instructions instead of writing no-op for the output of `workaroundSpecConstant`. Also, fix issue to keep the value in the original shader if a specialization wasn't provided.
poweifeng
added a commit
that referenced
this pull request
Dec 8, 2023
Swiftshader runs spirv validation before compilation. However, the validation does not like having Nop (no-op) in the input. So we skip instructions instead of writing no-op for the output of `workaroundSpecConstant`. Also, fix issue to keep the value in the original shader if a specialization wasn't provided.
plepers
pushed a commit
to plepers/filament
that referenced
this pull request
Dec 9, 2023
Swiftshader runs spirv validation before compilation. However, the validation does not like having Nop (no-op) in the input. So we skip instructions instead of writing no-op for the output of `workaroundSpecConstant`. Also, fix issue to keep the value in the original shader if a specialization wasn't provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiftshader runs spirv validation before compilation. However, the validation does not like having Nop (no-op) in the input. So we skip instructions instead of writing no-op for the output of
workaroundSpecConstant.Also, fix issue to keep the value in the original shader if a specialization wasn't provided.