Add a way to pass a transform matrix along with Stream::setAcquiredImage #8496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param for the associated transform matrix
…to track if the ubo needs to be updated.
… path can also update the transform in the shader.
pixelflinger
requested changes
Mar 6, 2025
| @@ -18,6 +18,7 @@ | |||
| #define TNT_FILAMENT_BACKEND_PRIVATE_ACQUIREDIMAGE_H | |||
|
|
|||
| #include <backend/DriverEnums.h> | |||
| #include "math/mat3.h" | |||
| @@ -176,7 +176,7 @@ class DriverBase : public Driver { | |||
| CallbackData(CallbackData&&) = delete; | |||
| CallbackData& operator=(CallbackData const &) = delete; | |||
| CallbackData& operator=(CallbackData&&) = delete; | |||
| void* storage[8] = {}; | |||
| void* storage[13] = {}; | |||
There was a problem hiding this comment.
you can't change that, it was very much chosen to be 64 bytes. there should have been a comment.
| @@ -2087,7 +2087,7 @@ Handle<HwStream> OpenGLDriver::createStreamAcquired() { | |||
| // called only once per frame. If the user pushes images to the same stream multiple times in a | |||
| // single frame, we emit a warning and honor only the final image, but still invoke all callbacks. | |||
| void OpenGLDriver::setAcquiredImage(Handle<HwStream> sh, void* hwbuffer, | |||
| CallbackHandler* handler, StreamCallback cb, void* userData) { | |||
| CallbackHandler* handler, StreamCallback cb, void* userData, math::mat3f transform) { | |||
There was a problem hiding this comment.
since we have access to the stream here, why do we need to receive the transform? can't we just ask the stream?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #8493
Streams in OpenGL are either backed by SurfaceTexture (Native in filament) or ImageReader (Acquired in filament). SurfaceTextures have a transform attached to the image that's updated every frame but have to be read from the GL thread. The ImageReader path has the same transform but is read from the main thread. The transform in the SurfaceTexture path can be optionally requested in the shader (see #8490). This PR adds a way for the ImageReader path to also update this transform.