stdinservice_test: Simplify platform differences #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/704729437
branch
2 times, most recently
from
d5e08b7 to
c87a46b
Compare
Python auto-converts newlines into the platform-dependent form, which trips up our equality check. Make sure that we don't have newlines in the output. Write through `sys.stdout` (it works in both Python 2 and Python 3) PiperOrigin-RevId: 706670816
copybara-service
bot
force-pushed
the
cl/704729437
branch
from
c87a46b to
67f05a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stdinservice_test: Simplify platform differences
Python auto-converts newlines into the platform-dependent form, which trips up
our equality check. Make sure that we don't have newlines in the output.
Write through
sys.stdout(it works in both Python 2 and Python 3)