Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: fix error checking for NotFound errors #3529

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

BrennaEpp
Copy link
Contributor

Fixes #3528

I have not tested this but it is a recommended change that I believe should fix the linked issue.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (da0b8ec) to head (fb89218).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3529      +/-   ##
==========================================
- Coverage   73.31%   73.29%   -0.02%     
==========================================
  Files         113      113              
  Lines       15190    15190              
==========================================
- Hits        11136    11134       -2     
- Misses       3275     3277       +2     
  Partials      779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@google-admin google-admin reopened this Mar 18, 2025
@vangent vangent merged commit c838139 into google:master Mar 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/gcsblob: Exists method should return false if the object doesn't exist instead of an error
3 participants