-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable file lock during listrepo operation #77
base: master
Are you sure you want to change the base?
Conversation
@@ -466,7 +466,7 @@ func main() { | |||
cmdr.ImportantFlag("verbose") | |||
cmdr.ImportantFlag("noconfirm") | |||
|
|||
nonLockingCommands := []string{"help", "commands", "flags"} | |||
nonLockingCommands := []string{"help", "commands", "flags", "listrepos"} | |||
if ggFlags.NArg() == 0 || goolib.ContainsString(ggFlags.Args()[0], nonLockingCommands) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to move the check on 474 above this as listrepos needs rootDir to be set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done,
I've attempted to maintain the existing logic to allow help&commands to proceed as before
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
This is intended to allow listrepo operations without elevated rights