-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate .eslintignore when running init #521
Conversation
@naseemkullah speaking with my colleague @JustinBeckwith, historically we populated a default
Rather than adding this into configuration, what if we were to again generate this file during initialization? |
sgtm @bcoe ooc is there any fundamental benefit to this approach over the other? |
@naseemkullah from my perspective, there tends to be a bit of variation in the sorts of files folks want to ignore on a project by project basis. for instance, as Googlers, we have protos/ generated in a lot of our libraries. The |
Thanks @bcoe I tried implementing this but am unsure how to test locally, could you please advise? |
ad37a76
to
43ebd01
Compare
@naseemkullah your test looks reasonable to me, to test you can go:
and see whether the file generates as expected. |
Thanks @bcoe, it appears that
did work and all is in order. |
I took the liberty of including another small fix, the prettier config was not generating with an empty line at eof but now is. |
Signed-off-by: Naseem <[email protected]>
@naseemkullah thank you for the contribution 👍 |
My pleasure @bcoe. |
generate
.eslintignore
and includebuild/
add empty line at enf of generated
.prettierrc.js
solves #483
solves #520