Implement IntMath.mod and LongMath.mod in terms of Math.floorMod.
#7803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_756744057
branch
5 times, most recently
from
2e5e0d8 to
5717694
Compare
Also, in `IntMath.divide` and `LongMath.divide`, document equivalent standard operations for two `RoundingMode` choices, and add tests showing that those are indeed equivalent. RELNOTES=n/a PiperOrigin-RevId: 758435908
copybara-service
bot
force-pushed
the
test_756744057
branch
from
5717694 to
69cad18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
IntMath.modandLongMath.modin terms ofMath.floorMod.Also, in
IntMath.divideandLongMath.divide, document equivalent standard operations for twoRoundingModechoices, and add tests showing that those are indeed equivalent.RELNOTES=n/a