TFHE-rs HL Emitter #1250
Merged
TFHE-rs HL Emitter #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoutLegiest
force-pushed
the
quater-emit-trans
branch
from
7c23d4e to
396100b
Compare
j2kun
reviewed
Jan 11, 2025
WoutLegiest
force-pushed
the
quater-emit-trans
branch
3 times, most recently
from
b454b9c to
ffcbc84
Compare
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
j2kun
reviewed
Jan 13, 2025
WoutLegiest
force-pushed
the
quater-emit-trans
branch
2 times, most recently
from
ef41055 to
e6bfcdc
Compare
|
Is this one ready for merging? It seems to need a rebase. |
WoutLegiest
force-pushed
the
quater-emit-trans
branch
2 times, most recently
from
afd8d3f to
7bcfbe8
Compare
Testing is now working. Ready for re-review / merging |
WoutLegiest
force-pushed
the
quater-emit-trans
branch
2 times, most recently
from
659cc6f to
bc835a0
Compare
WoutLegiest
force-pushed
the
quater-emit-trans
branch
from
bc835a0 to
c89685e
Compare
j2kun
approved these changes
Jan 15, 2025
j2kun
added
the
pull_ready
asraa
approved these changes
Jan 15, 2025
| @@ -42,7 +46,8 @@ LogicalResult canEmitFuncForTfheRust(func::FuncOp &funcOp) { | |||
| llvm::errs() | |||
| << "Skipping function " << funcOp.getName() | |||
| << " which cannot be emitted because it has an unsupported op: " | |||
| << *op << "\n"; | |||
| << *op << "\n" | |||
| << "Origin: TfheRust/Utils.cpp:canEmitFuncForTfheRust\n"; | |||
There was a problem hiding this comment.
is this leftover? maybe remove in the follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Up of #1248 and #1249
First conversion pass to lower the (TOSA orginated) Arith dialect to CGGI to TFHE-rs HL