Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pyink formatter in pre-commit and apply to all files #1341

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Jan 30, 2025

Note https://github.com/google/pyink is a fork of black with some patches to support Google's internal style guide. The configuration I set in pyproject.toml corresponds to the options making pyink consistent with Google's internal style guide.

Eventually they hope to upstream all their patches to black, and they have been making some progress on this. But in the end we may be stuck with pyink for a while.

Their repo has instructions for getting it set up with VSCode. I haven't yet had the time to get it set up with vim/NeoVim, but if there are any other dinosaurs wizards like me who want my config let me know and I can share it.

Copy link
Collaborator

@AlexanderViand-Intel AlexanderViand-Intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you also add a mention to the "Developer" documentation, something like the sentence from the PR description about setting up vscode?

@j2kun
Copy link
Collaborator Author

j2kun commented Jan 30, 2025

Added a note and squashed

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jan 30, 2025
@copybara-service copybara-service bot merged commit 2c118a3 into google:main Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python autoformatting for the project
2 participants