Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS-Fuzz: Fuzzer improvements #3786

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

OSS-Fuzz: Fuzzer improvements #3786

wants to merge 5 commits into from
+403 −14

Conversation

pacbypass
Copy link

This PR improves the previously implemented fuzzers for libphonenumber.

The exact changes are as follows:

  • Improve coverage of phonenumberutil.cc
  • Add fuzzer for the c++ PhoneNumberMatch / PhoneNumberMatcher
  • Add fuzzer for ShortNumberInfo - this component is not even included in the current fuzzer, so oss-fuzz did not measure coverage of the project properly.
  • Add fuzzer for the c++ AsYouTypeFormatter

A new build script will be a separate pull request to OSS-Fuzz.

@pacbypass pacbypass requested a review from a team as a code owner January 16, 2025 13:51
@pacbypass
Copy link
Author

Hey there @tvislavski @silvio2402 Please take a look. Tagging @DavidKorczynski on OSS-Fuzz side for awareness of this PR.

@tvislavski tvislavski requested a review from mandlil February 19, 2025 22:08
tvislavski
tvislavski requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@tvislavski tvislavski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the renaming of fuzz_phone so it's clearly visible what are the changes to that file?

@pacbypass
Copy link
Author

Done!

@pacbypass pacbypass requested a review from tvislavski February 20, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandlil mandlil Awaiting requested review from mandlil

@tvislavski tvislavski Awaiting requested review from tvislavski

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacbypass @tvislavski